Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flaky test is found in this project and this PR proposes to fix it.
javaJDK8
.mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=fr.xephi.authme.listener.PlayerListenerTest#shouldHideChatFromUnauthed
, which producesPlayerListenerTest.shouldHideChatFromUnauthed:348 Expected: iterable containing [<Mock for Player, hashCode: 775174220>, <Mock for Player, hashCode: 810672306>] but: item 0: was <Mock for Player, hashCode: 810672306>
.org.bukkit.event.player.AsyncPlayerChatEvent.getRecipients()
called in the testfr.xephi.authme.listener.PlayerListenerTest.shouldHideChatFromUnauthed
returns a set, which does not guarantee the order of the elements in it.contains
inshouldHideChatFromUnauthed
is changed tocontainsInAnyOrder
, and the functionorg.hamcrest.Matchers.containsInAnyOrder
is imported instead oforg.hamcrest.Matchers.contains
.